Issue 723893002: Decrease size of test of write barrier verification.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 723893002: Decrease size of test of write barrier verification. (Closed)

Created:
6 years, 1 month ago by koda

Modified:
6 years, 1 month ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Decrease size of test of write barrier verification. It was close to timing out on Linux, and failing on Windows, likely due to OOM. TBR=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=41702

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tests/standalone/verified_mem_test.dart	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

koda

Committed patchset #1 (id:1) manually as r41702 (presubmit successful).

6 years, 1 month ago (2014-11-13 02:53:55 UTC) #2

Ivan Posva

6 years, 1 month ago (2014-11-13 16:55:37 UTC) #3

Message was sent while issue was closed.

LGTM -ip

https://codereview.chromium.org/723893002/diff/1/tests/standalone/verified_me...
File tests/standalone/verified_mem_test.dart (right):

https://codereview.chromium.org/723893002/diff/1/tests/standalone/verified_me...
tests/standalone/verified_mem_test.dart:6: // VMOptions=--verified_mem
--verify_before_gc --verify_after_gc
You might also want to reduce the growth of old gen policy manually, so that you
run more frequent old generation GCs.

Expand Messages | Collapse Messages