Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 723523003: Avoid emmitting is test for Function if superclass already has it. (Closed)

Created:
6 years, 1 month ago by herhut
Modified:
6 years, 1 month ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, sra1, karlklose
Visibility:
Public.

Description

Avoid emmitting is test for Function if superclass already has it. R=johnniwinther@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41690

Patch Set 1 #

Total comments: 2

Patch Set 2 : spelling fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart View 1 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
herhut
6 years, 1 month ago (2014-11-12 14:07:17 UTC) #1
Johnni Winther
lgtm https://codereview.chromium.org/723523003/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart File pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart (right): https://codereview.chromium.org/723523003/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart#newcode172 pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart:172: // a case, we can avoid emmiting the ...
6 years, 1 month ago (2014-11-12 14:15:01 UTC) #2
herhut
https://codereview.chromium.org/723523003/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart File pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart (right): https://codereview.chromium.org/723523003/diff/1/pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart#newcode172 pkg/compiler/lib/src/js_emitter/old_emitter/type_test_emitter.dart:172: // a case, we can avoid emmiting the is ...
6 years, 1 month ago (2014-11-12 14:29:18 UTC) #3
herhut
6 years, 1 month ago (2014-11-12 14:39:05 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41690 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698