Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 723393003: update to polymer js 0.5.1 (Closed)

Created:
6 years, 1 month ago by jakemac
Modified:
6 years ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : little bit of cleanup #

Total comments: 57

Patch Set 3 : code review updates, cherry pick https://github.com/Polymer/webcponentsjs/pull/58 #

Patch Set 4 : fix cherrypick #

Patch Set 5 : fix http://dartbug.com/20197, extending from a custom element will no longer cause an instance of t… #

Patch Set 6 : update test now that issue 20197 is fixed #

Patch Set 7 : final tweaks #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18805 lines, -24223 lines) Patch
M pkg/observe/CHANGELOG.md View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/observe/lib/src/path_observer.dart View 1 2 3 4 5 6 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/observe/pubspec.yaml View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M pkg/pkg.status View 1 2 3 4 5 6 4 chunks +4 lines, -2 lines 0 comments Download
M pkg/polymer/CHANGELOG.md View 1 2 3 4 5 6 1 chunk +13 lines, -1 line 0 comments Download
M pkg/polymer/e2e_test/bad_import1/test/import_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/e2e_test/bad_import2/test/import_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/e2e_test/bad_import3/test/import_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/e2e_test/canonicalization/test/deploy1_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/e2e_test/canonicalization/test/deploy2_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/e2e_test/canonicalization/test/deploy3_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/e2e_test/canonicalization/test/dev1_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/e2e_test/canonicalization/test/dev2_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/e2e_test/canonicalization/test/dev3_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/e2e_test/canonicalization/test/dir/deploy1_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/e2e_test/canonicalization/test/dir/deploy2_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/e2e_test/canonicalization/test/dir/dev1_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/e2e_test/canonicalization/test/dir/dev2_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/e2e_test/experimental_boot/test/double_init_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/e2e_test/experimental_boot/test/import_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/e2e_test/good_import/test/import_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/example/component/news/test/news_index_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/lib/builder.dart View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/lib/deploy.dart View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/lib/polymer.html View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/lib/src/build/common.dart View 1 2 3 4 5 6 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/polymer/lib/src/build/generated/messages.html View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/lib/src/build/import_inliner.dart View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/lib/src/build/linter.dart View 1 2 3 4 5 6 1 chunk +8 lines, -0 lines 0 comments Download
M pkg/polymer/lib/src/build/messages.dart View 1 2 3 4 5 6 3 chunks +31 lines, -6 lines 0 comments Download
M pkg/polymer/lib/src/build/polyfill_injector.dart View 1 2 3 4 5 6 4 chunks +17 lines, -11 lines 0 comments Download
M pkg/polymer/lib/src/declaration.dart View 1 2 3 4 5 6 7 chunks +41 lines, -4 lines 0 comments Download
M pkg/polymer/lib/src/instance.dart View 1 2 3 4 5 6 20 chunks +126 lines, -44 lines 1 comment Download
M pkg/polymer/lib/src/js/polymer/polymer.html View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/lib/src/js/polymer/polymer.js View 1 2 3 4 5 6 1 chunk +11820 lines, -6 lines 0 comments Download
D pkg/polymer/lib/src/js/polymer/polymer.concat.js View 1 2 3 4 5 6 1 chunk +0 lines, -10981 lines 0 comments Download
D pkg/polymer/lib/src/js/polymer/polymer.concat.js.map View 1 2 3 4 5 6 1 chunk +0 lines, -120 lines 0 comments Download
D pkg/polymer/lib/src/js/polymer/polymer.js.map View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
A pkg/polymer/lib/src/js/polymer/polymer.min.js View 1 2 3 4 5 6 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/polymer/lib/src/loader.dart View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
M pkg/polymer/lib/transformer.dart View 1 2 3 4 5 6 2 chunks +11 lines, -2 lines 0 comments Download
M pkg/polymer/pubspec.yaml View 1 2 3 4 5 6 3 chunks +4 lines, -8 lines 0 comments Download
M pkg/polymer/test/attr_deserialize_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/attr_mustache_test.dart View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/attr_mustache_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/auto_binding_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/bind_mdv_test.html View 1 2 3 4 5 6 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/polymer/test/bind_properties_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/bind_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/build/all_phases_test.dart View 1 2 3 4 5 6 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/polymer/test/build/common.dart View 1 2 3 4 5 6 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/polymer/test/build/linter_test.dart View 1 2 3 4 5 6 1 chunk +24 lines, -0 lines 0 comments Download
M pkg/polymer/test/build/polyfill_injector_test.dart View 1 2 3 4 5 6 3 chunks +33 lines, -11 lines 0 comments Download
M pkg/polymer/test/computed_properties_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/custom_event_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
A pkg/polymer/test/element_import/import_a.dart View 1 2 3 4 5 6 1 chunk +10 lines, -0 lines 0 comments Download
A pkg/polymer/test/element_import/import_a.html View 1 2 3 4 5 6 1 chunk +16 lines, -0 lines 0 comments Download
A pkg/polymer/test/element_import/import_b.dart View 1 2 3 4 5 6 1 chunk +10 lines, -0 lines 0 comments Download
A pkg/polymer/test/element_import/import_b.html View 1 2 3 4 5 6 1 chunk +16 lines, -0 lines 0 comments Download
M pkg/polymer/test/entered_view_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/event_binding_release_handler_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/event_handlers_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/event_path_declarative_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/event_path_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/events_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/force_ready_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
A pkg/polymer/test/import_test.dart View 1 2 3 4 5 6 1 chunk +29 lines, -0 lines 0 comments Download
A + pkg/polymer/test/import_test.html View 1 2 3 4 5 6 2 chunks +9 lines, -7 lines 0 comments Download
M pkg/polymer/test/inject_bound_html_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/instance_attrs_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/js_custom_event_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/js_interop_test.dart View 1 2 3 4 5 6 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/polymer/test/js_interop_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/layout_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/nested_binding_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/noscript_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
D pkg/polymer/test/platform_less_test.dart View 1 2 3 4 5 6 1 chunk +0 lines, -48 lines 0 comments Download
D pkg/polymer/test/platform_less_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -31 lines 0 comments Download
D pkg/polymer/test/platform_less_test_import.html View 1 2 3 4 5 6 1 chunk +0 lines, -6 lines 0 comments Download
M pkg/polymer/test/prop_attr_bind_reflection_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/prop_attr_reflection_test.dart View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M pkg/polymer/test/prop_attr_reflection_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/property_change_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/property_observe_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/publish_attributes_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/publish_inherited_properties_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/register_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/take_attributes_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/template_attr_template_test.dart View 1 2 3 4 5 6 1 chunk +1 line, -2 lines 1 comment Download
M pkg/polymer/test/template_attr_template_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/template_distribute_dynamic_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/two_way_bind_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/polymer/test/unbind_test.html View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
A + pkg/polymer/test/web_components_less_test.dart View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
A + pkg/polymer/test/web_components_less_test.html View 1 2 3 4 5 6 2 chunks +3 lines, -4 lines 0 comments Download
A + pkg/polymer/test/web_components_less_test_import.html View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
M pkg/polymer_expressions/pubspec.yaml View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M pkg/template_binding/CHANGELOG.md View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
A + pkg/template_binding/lib/js/flush.js View 1 2 3 4 5 6 3 chunks +46 lines, -7 lines 0 comments Download
M pkg/template_binding/lib/js/microtask.js View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/template_binding/lib/js/observe.js View 1 2 3 4 5 6 6 chunks +39 lines, -36 lines 0 comments Download
D pkg/template_binding/lib/js/patches_mdv.js View 1 2 3 4 5 6 1 chunk +0 lines, -58 lines 0 comments Download
M pkg/template_binding/pubspec.yaml View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/template_binding/test/custom_element_bindings_test.html View 1 2 3 4 5 6 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/template_binding/test/node_bind_test.html View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/template_binding/test/template_binding_test.html View 1 2 3 4 5 6 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/web_components/CHANGELOG.md View 1 2 3 4 5 6 5 chunks +23 lines, -16 lines 0 comments Download
M pkg/web_components/README.md View 1 2 3 4 5 6 2 chunks +8 lines, -25 lines 0 comments Download
D pkg/web_components/lib/platform.js View 1 2 3 4 5 6 1 chunk +0 lines, -17 lines 0 comments Download
D pkg/web_components/lib/platform.concat.js View 1 2 3 4 5 6 1 chunk +0 lines, -12449 lines 0 comments Download
D pkg/web_components/lib/platform.concat.js.map View 1 2 3 4 5 6 1 chunk +0 lines, -160 lines 0 comments Download
D pkg/web_components/lib/platform.js.map View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
A pkg/web_components/lib/webcomponents.js View 1 2 3 4 5 6 1 chunk +6373 lines, -0 lines 0 comments Download
A pkg/web_components/lib/webcomponents.min.js View 1 2 3 4 5 6 1 chunk +14 lines, -0 lines 0 comments Download
M pkg/web_components/pubspec.yaml View 1 2 3 4 5 6 2 chunks +1 line, -14 lines 0 comments Download
A + samples/.gitignore View 1 2 3 4 5 6 0 chunks +-1 lines, --1 lines 0 comments Download
M samples/third_party/todomvc/pubspec.yaml View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M samples/third_party/todomvc/test/markdone_shadow_test.html View 1 2 3 4 5 6 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
jakemac
6 years, 1 month ago (2014-11-21 21:58:11 UTC) #2
Siggi Cherem (dart-lang)
great work Jake! looks great, just minor comments below, but otherwise lgtm https://codereview.chromium.org/723393003/diff/10001/pkg/observe/lib/src/path_observer.dart File pkg/observe/lib/src/path_observer.dart ...
6 years ago (2014-11-25 17:53:42 UTC) #3
jakemac
https://codereview.chromium.org/723393003/diff/10001/pkg/observe/lib/src/path_observer.dart File pkg/observe/lib/src/path_observer.dart (right): https://codereview.chromium.org/723393003/diff/10001/pkg/observe/lib/src/path_observer.dart#newcode236 pkg/observe/lib/src/path_observer.dart:236: // _segments[0] is passed to indicate that we are ...
6 years ago (2014-12-01 18:42:52 UTC) #4
Siggi Cherem (dart-lang)
lgtm although the visibility_test files seem to be missing from the last patchset https://codereview.chromium.org/723393003/diff/10001/pkg/polymer/lib/src/instance.dart File ...
6 years ago (2014-12-02 01:31:26 UTC) #5
jakemac
https://codereview.chromium.org/723393003/diff/10001/pkg/polymer/lib/src/instance.dart File pkg/polymer/lib/src/instance.dart (right): https://codereview.chromium.org/723393003/diff/10001/pkg/polymer/lib/src/instance.dart#newcode1161 pkg/polymer/lib/src/instance.dart:1161: _Polymer.callMethod('flush'); // for polymer-js interop On 2014/12/02 01:31:26, Siggi ...
6 years ago (2014-12-03 18:34:57 UTC) #6
Siggi Cherem (dart-lang)
lgtm! https://codereview.chromium.org/723393003/diff/60001/pkg/polymer/lib/src/instance.dart File pkg/polymer/lib/src/instance.dart (right): https://codereview.chromium.org/723393003/diff/60001/pkg/polymer/lib/src/instance.dart#newcode171 pkg/polymer/lib/src/instance.dart:171: (js.context['HTMLElement']['register'] as JsFunction).apply( I can't believe they monkey ...
6 years ago (2014-12-04 00:32:18 UTC) #7
jakemac
6 years ago (2014-12-04 17:14:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #7 (id:60001) manually as 42114 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698