Make better use of one-letter names when minifying.

Make better use of one-letter names when minifying.

BUG=
R=sra@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41731

[herhut, 2014-11-13 15:13:54]

herhut@google.com changed reviewers:
+ sra@google.com

[herhut, 2014-11-13 15:15:33]

I have updated the built in table of common identifiers to reflect what we
actually generate nowadays. Also, I have enabled the use of the remaining on
letter identifiers for general minification.

[sra1, 2014-11-13 23:52:25]

lgtm

https://codereview.chromium.org/723063003/diff/1/pkg/compiler/lib/src/js_back...
File pkg/compiler/lib/src/js_backend/minify_namer.dart (right):

https://codereview.chromium.org/723063003/diff/1/pkg/compiler/lib/src/js_back...
pkg/compiler/lib/src/js_backend/minify_namer.dart:178: (n != 1 ||
!suggestions.contains(candidate))) {
Iterable.contains is not particularly fast.

[herhut, 2014-11-14 08:44:42]

Thanks!

https://codereview.chromium.org/723063003/diff/1/pkg/compiler/lib/src/js_back...
File pkg/compiler/lib/src/js_backend/minify_namer.dart (right):

https://codereview.chromium.org/723063003/diff/1/pkg/compiler/lib/src/js_back...
pkg/compiler/lib/src/js_backend/minify_namer.dart:178: (n != 1 ||
!suggestions.contains(candidate))) {
On 2014/11/13 23:52:25, sra1 wrote:
> Iterable.contains is not particularly fast.

I know but it is not called that often. Only for one-letter names, and then only
if they have not been used before (usedNames). So no more than 62 times (less
actually as some even are reserved).

[herhut, 2014-11-14 08:46:56]

Committed patchset #1 (id:1) manually as 41731 (presubmit successful).