Issue 722793002: Revert "Suppress canonicalization of Unbox() instruction that can deoptimize."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 722793002: Revert "Suppress canonicalization of Unbox() instruction that can deoptimize." (Closed)

Created:
6 years, 1 month ago by Vyacheslav Egorov (Google)

Modified:
6 years, 1 month ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "Suppress canonicalization of Unbox() instruction that can deoptimize." This reverts commit r41693 due to checked mode test failures. TBR=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41695

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -45 lines)			Patch
M	runtime/vm/flow_graph_optimizer.cc	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	3 chunks	+11 lines, -16 lines	0 comments	Download
D	tests/language/vm/canonicalization_preserves_deopt_test.dart	View	1 chunk	+0 lines, -20 lines	0 comments	Download

Total messages: 3 (0 generated)

Vyacheslav Egorov (Google)

Committed patchset #1 (id:1) manually as 41695 (presubmit successful).

6 years, 1 month ago (2014-11-12 18:57:42 UTC) #2

Message was sent while issue was closed.

lgtm