Issue 722163002: Add support for static calls to the cps pipeline code generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 722163002: Add support for static calls to the cps pipeline code generator. (Closed)

Created:
6 years, 1 month ago by sigurdm

Modified:
6 years, 1 month ago

Reviewers:
floitsch

CC:
reviews_dartlang.org, karlklose

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add support for static calls to the cps pipeline code generator. Applies on top of https://codereview.chromium.org/716823002/ R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=41800

Patch Set 2 : Rebase, and make Glue.namer private #

Patch Set 3 : Add test #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -6 lines)			Patch
M	pkg/compiler/lib/src/compiler.dart	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/codegen.dart	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/glue.dart	View	1	3 chunks	+6 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/ssa/codegen.dart	View	1	2 chunks	+2 lines, -3 lines	0 comments	Download
M	tests/compiler/dart2js/js_backend_cps_ir_test.dart	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

floitsch

LGTM. https://codereview.chromium.org/722163002/diff/1/pkg/compiler/lib/src/js_backend/codegen/glue.dart File pkg/compiler/lib/src/js_backend/codegen/glue.dart (right): https://codereview.chromium.org/722163002/diff/1/pkg/compiler/lib/src/js_backend/codegen/glue.dart#newcode23 pkg/compiler/lib/src/js_backend/codegen/glue.dart:23: Namer get namer => backend.namer; make private.

6 years, 1 month ago (2014-11-13 14:41:57 UTC) #3

sigurdm

6 years, 1 month ago (2014-11-18 13:08:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 41800 (presubmit successful).