Clean up version solver tests a bit.

Clean up version solver tests a bit.

The code for parsing the package descriptions had gotten increasingly
hacky. This unhacks it.

R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30264

[Bob Nystrom, 2013-11-14 00:46:16]

A little prep work before adding dependency override tests.

[nweiz, 2013-11-14 01:16:14]

A couple suggestions, but lgtm.

https://codereview.chromium.org/72193002/diff/1/sdk/lib/_internal/pub/test/ve...
File sdk/lib/_internal/pub/test/version_solver_test.dart (right):

https://codereview.chromium.org/72193002/diff/1/sdk/lib/_internal/pub/test/ve...
sdk/lib/_internal/pub/test/version_solver_test.dart:1244: assert(match != null);
Throw an error message that includes [text]. If someone actually does add a spec
with a typo, it'll be really helpful to tell them which spec they did wrong.

https://codereview.chromium.org/72193002/diff/1/sdk/lib/_internal/pub/test/ve...
sdk/lib/_internal/pub/test/version_solver_test.dart:1252: assert(match[5] ==
null);
See above.

[Bob Nystrom, 2013-11-14 01:40:00]

Committed patchset #2 manually as r30264 (presubmit successful).

[Bob Nystrom, 2013-11-21 18:19:56]

Oops, never sent this.

https://codereview.chromium.org/72193002/diff/1/sdk/lib/_internal/pub/test/ve...
File sdk/lib/_internal/pub/test/version_solver_test.dart (right):

https://codereview.chromium.org/72193002/diff/1/sdk/lib/_internal/pub/test/ve...
sdk/lib/_internal/pub/test/version_solver_test.dart:1244: assert(match != null);
On 2013/11/14 01:16:14, nweiz wrote:
> Throw an error message that includes [text]. If someone actually does add a
spec
> with a typo, it'll be really helpful to tell them which spec they did wrong.

Done.

https://codereview.chromium.org/72193002/diff/1/sdk/lib/_internal/pub/test/ve...
sdk/lib/_internal/pub/test/version_solver_test.dart:1252: assert(match[5] ==
null);
On 2013/11/14 01:16:14, nweiz wrote:
> See above.

Done.