Issue 721223002: Remove unused methods in analysis_server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 721223002: Remove unused methods in analysis_server. (Closed)

Created:
6 years, 1 month ago by scheglov

Modified:
6 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove unused methods in analysis_server. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41718

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -39 lines)			Patch
M	pkg/analysis_server/bin/fuzz.dart	View	1 chunk	+0 lines, -6 lines	1 comment	Download
M	pkg/analysis_server/lib/src/computer/computer_navigation.dart	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/index/store/codec.dart	View	2 chunks	+0 lines, -16 lines	0 comments	Download
M	pkg/analysis_server/test/analysis_abstract.dart	View	1 chunk	+0 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/721223002/diff/1/pkg/analysis_server/bin/fuzz.dart File pkg/analysis_server/bin/fuzz.dart (left): https://codereview.chromium.org/721223002/diff/1/pkg/analysis_server/bin/fuzz.dart#oldcode157 pkg/analysis_server/bin/fuzz.dart:157: void _printAnalysisSummary(AnalysisResults results) { You should check with ...

6 years, 1 month ago (2014-11-13 16:11:35 UTC) #2

scheglov

6 years, 1 month ago (2014-11-13 16:27:16 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 41718 (presubmit successful).

Expand Messages | Collapse Messages