Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 720543002: First fix for indexing slowness. (Closed)

Created:
6 years, 1 month ago by scheglov
Modified:
6 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

First fix for indexing slowness. We can make it even faster, but this change alone reduces time from 55000 ms to 22600 ms. R=paulberry@google.com, brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41679

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M pkg/analyzer/lib/src/generated/source_io.dart View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
6 years, 1 month ago (2014-11-11 22:51:35 UTC) #1
Paul Berry
lgtm
6 years, 1 month ago (2014-11-11 23:04:05 UTC) #3
scheglov
Committed patchset #1 (id:1) manually as 41679 (presubmit successful).
6 years, 1 month ago (2014-11-11 23:05:52 UTC) #4
Brian Wilkerson
6 years, 1 month ago (2014-11-12 14:46:05 UTC) #5
Message was sent while issue was closed. 
LGTM

Powered by Google App Engine
This is Rietveld 408576698