Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 720153003: In ListBase always return Iterable with the correct type argument. (Closed)

Created:
6 years, 1 month ago by Florian Schneider
Modified:
6 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

In ListBase always return Iterable with the correct type argument. R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=41737

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M sdk/lib/collection/list.dart View 1 3 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Florian Schneider
I found these places where the type argument of the ListBase is not passed on ...
6 years, 1 month ago (2014-11-13 15:15:39 UTC) #2
Lasse Reichstein Nielsen
lgtm
6 years, 1 month ago (2014-11-14 11:25:24 UTC) #3
Florian Schneider
6 years, 1 month ago (2014-11-14 11:34:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r41737 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698