Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 719383003: Improvements and tests for top-level variables matching. (Closed)

Created:
6 years, 1 month ago by scheglov
Modified:
6 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Improvements and tests for top-level variables matching. It is OK to reorder them. But it is not OK to change number of them or their types. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41839

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+262 lines, -77 lines) Patch
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 27 chunks +155 lines, -61 lines 0 comments Download
M pkg/analyzer/test/generated/incremental_resolver_test.dart View 3 chunks +107 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 1 month ago (2014-11-19 19:06:58 UTC) #1
Brian Wilkerson
LGTM
6 years, 1 month ago (2014-11-19 19:30:18 UTC) #2
scheglov
6 years, 1 month ago (2014-11-19 19:31:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41839 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698