Issue 719223002: Move unused local variables and classes analysis into HintGenerator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 719223002: Move unused local variables and classes analysis into HintGenerator. (Closed)

Created:
6 years, 1 month ago by scheglov

Modified:
6 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Move unused local variables and classes analysis into HintGenerator. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41696

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+177 lines, -154 lines)			Patch
M	pkg/analyzer/lib/src/generated/element.dart	View	5 chunks	+0 lines, -45 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/element_resolver.dart	View	2 chunks	+0 lines, -24 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	10 chunks	+177 lines, -85 lines	0 comments	Download

Total messages: 3 (0 generated)

Brian Wilkerson

LGTM, as long as you have run this over some large code bases to test ...

6 years, 1 month ago (2014-11-12 19:57:09 UTC) #2

scheglov

6 years, 1 month ago (2014-11-12 20:04:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 41696 (presubmit successful).