Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 718703002: Update enum encoding to latest spec. (Closed)

Created:
6 years, 1 month ago by Johnni Winther
Modified:
6 years, 1 month ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Update enum encoding to latest spec. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=41685

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -35 lines) Patch
M pkg/compiler/lib/src/resolution/enum_creator.dart View 1 7 chunks +69 lines, -35 lines 0 comments Download
A tests/language/enum_test.dart View 1 chunk +110 lines, -0 lines 0 comments Download
M tests/language/language.status View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
6 years, 1 month ago (2014-11-11 12:53:25 UTC) #2
floitsch
LGTM. https://codereview.chromium.org/718703002/diff/1/pkg/compiler/lib/src/resolution/enum_creator.dart File pkg/compiler/lib/src/resolution/enum_creator.dart (right): https://codereview.chromium.org/718703002/diff/1/pkg/compiler/lib/src/resolution/enum_creator.dart#newcode23 pkg/compiler/lib/src/resolution/enum_creator.dart:23: Modifiers finalModifiers() { make getter or rename.
6 years, 1 month ago (2014-11-11 13:22:10 UTC) #3
Johnni Winther
Committed patchset #2 (id:20001) manually as 41685 (presubmit successful).
6 years, 1 month ago (2014-11-12 08:07:17 UTC) #4
Johnni Winther
6 years, 1 month ago (2014-11-12 10:16:29 UTC) #5
Message was sent while issue was closed. 
https://codereview.chromium.org/718703002/diff/1/pkg/compiler/lib/src/resolut...
File pkg/compiler/lib/src/resolution/enum_creator.dart (right):

https://codereview.chromium.org/718703002/diff/1/pkg/compiler/lib/src/resolut...
pkg/compiler/lib/src/resolution/enum_creator.dart:23: Modifiers finalModifiers()
{
On 2014/11/11 13:22:09, floitsch wrote:
> make getter or rename.

Unified these methods to one [modifiers] method.

Powered by Google App Engine
This is Rietveld 408576698