Issue 718323002: Report HintCode.UNUSED_ELEMENT for unused methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 718323002: Report HintCode.UNUSED_ELEMENT for unused methods. (Closed)

Created:
6 years, 1 month ago by scheglov

Modified:
6 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Report HintCode.UNUSED_ELEMENT for unused methods. No positives in dart2js. Several positives in analyzer - not finished _notifyX methods in AnalysisContextImpl, not used (saved for later?) methods in BestPracticesVerifier, some other methods. Several positives in analysis_server, actual problems. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41717

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+288 lines, -13 lines)			Patch
	M	pkg/analyzer/lib/src/generated/resolver.dart	View		8 chunks	+67 lines, -12 lines	0 comments	Download
	M	pkg/analyzer/test/generated/resolver_test.dart	View		2 chunks	+221 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

6 years, 1 month ago (2014-11-13 15:41:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 41717 (presubmit successful).

Expand Messages | Collapse Messages