Issue 718053003: Reduce foot-print of Error.safeToString on strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 718053003: Reduce foot-print of Error.safeToString on strings. (Closed)

Created:
6 years, 1 month ago by Lasse Reichstein Nielsen

Modified:
6 years, 1 month ago

Reviewers:
floitsch, sra1

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Reduce foot-print of Error.safeToString on strings. Use existing JSON encoding instead of a custom encoding. This allows dart2js to use the system JSON stringifier directly. R=sra@google.com Committed: https://code.google.com/p/dart/source/detail?r=41704

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -46 lines)			Patch
M	runtime/lib/errors_patch.dart	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/core_patch.dart	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/js_lib/js_helper.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	sdk/lib/core/errors.dart	View	1 chunk	+4 lines, -42 lines	0 comments	Download
M	tests/corelib/safe_to_string_test.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Total messages: 4 (1 generated)

Lasse Reichstein Nielsen

6 years, 1 month ago (2014-11-13 06:47:34 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r41704 (presubmit successful).