Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 717103004: Revert "Emit warning on import of dart:mirrors." (Closed)

Created:
6 years, 1 month ago by floitsch
Modified:
6 years, 1 month ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Emit warning on import of dart:mirrors." This reverts commit r41688. Committed: https://code.google.com/p/dart/source/detail?r=41692

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -621 lines) Patch
M pkg/compiler/lib/src/apiimpl.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 7 chunks +33 lines, -141 lines 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/dart2jslib.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/dart_backend.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 3 chunks +5 lines, -70 lines 0 comments Download
M pkg/compiler/lib/src/util/uri_extras.dart View 3 chunks +11 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/warnings.dart View 1 chunk +0 lines, -24 lines 0 comments Download
M tests/compiler/dart2js/exit_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
D tests/compiler/dart2js/import_mirrors_test.dart View 1 chunk +0 lines, -316 lines 0 comments Download
M tests/compiler/dart2js/memory_compiler.dart View 3 chunks +2 lines, -26 lines 0 comments Download
M tests/compiler/dart2js/message_kind_helper.dart View 1 chunk +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/message_kind_test.dart View 1 chunk +2 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/mirrors_used_test.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
floitsch
Unfortunately the build stayed red... TBR.
6 years, 1 month ago (2014-11-12 15:28:27 UTC) #2
floitsch
Committed patchset #1 (id:1) manually as 41692 (presubmit successful).
6 years, 1 month ago (2014-11-12 15:29:00 UTC) #3
floitsch
I didn't revert the status-file update (that was committed in a follow-up CL).
6 years, 1 month ago (2014-11-12 15:30:20 UTC) #4
Johnni Winther
6 years, 1 month ago (2014-11-13 08:17:51 UTC) #5
Message was sent while issue was closed. 
LGTM Thanks!

Powered by Google App Engine
This is Rietveld 408576698