Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 716913005: Replace ResolvedNode by ConstantExpression. (Closed)

Created:
6 years, 1 month ago by Johnni Winther
Modified:
6 years, 1 month ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org, Alan Knight
Visibility:
Public.

Description

Replace ResolvedNode by ConstantExpression. BUG=http://dartbug.com/21493 R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=41709

Patch Set 1 #

Patch Set 2 : Add unittest #

Total comments: 4

Patch Set 3 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -174 lines) Patch
M pkg/compiler/lib/src/constants/expressions.dart View 20 chunks +68 lines, -40 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart View 8 chunks +14 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart View 2 chunks +14 lines, -30 lines 0 comments Download
M pkg/docgen/lib/src/models/annotation.dart View 1 2 chunks +2 lines, -84 lines 0 comments Download
M pkg/docgen/lib/src/models/model_helpers.dart View 1 2 chunks +105 lines, -6 lines 0 comments Download
A pkg/docgen/test/metadata_test.dart View 1 2 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
6 years, 1 month ago (2014-11-12 10:47:14 UTC) #2
sigurdm
lgtm https://codereview.chromium.org/716913005/diff/20001/pkg/compiler/lib/src/constants/expressions.dart File pkg/compiler/lib/src/constants/expressions.dart (right): https://codereview.chromium.org/716913005/diff/20001/pkg/compiler/lib/src/constants/expressions.dart#newcode286 pkg/compiler/lib/src/constants/expressions.dart:286: class ConstExpPrinter extends ConstantExpressionVisitor { Shouldn't there be ...
6 years, 1 month ago (2014-11-12 12:10:23 UTC) #3
Johnni Winther
https://codereview.chromium.org/716913005/diff/20001/pkg/compiler/lib/src/constants/expressions.dart File pkg/compiler/lib/src/constants/expressions.dart (right): https://codereview.chromium.org/716913005/diff/20001/pkg/compiler/lib/src/constants/expressions.dart#newcode286 pkg/compiler/lib/src/constants/expressions.dart:286: class ConstExpPrinter extends ConstantExpressionVisitor { On 2014/11/12 12:10:23, sigurdm ...
6 years, 1 month ago (2014-11-13 10:16:42 UTC) #4
Johnni Winther
6 years, 1 month ago (2014-11-13 10:22:56 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:30001) manually as 41709 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698