Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Issue 716403003: Concurrent sweep on x64. (Closed)

Created:
6 years, 1 month ago by koda
Modified:
6 years, 1 month ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Concurrent sweep on x64. Analogous to the ia32 change: https://codereview.chromium.org/624473003/ Update header word atomically in generated code. Also convert unused LockCmpxchgl to LockCmpxchgq. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=41756

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -28 lines) Patch
M runtime/vm/assembler_x64.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M runtime/vm/pages.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 2 1 chunk +25 lines, -17 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
koda
6 years, 1 month ago (2014-11-13 17:52:48 UTC) #1
Ivan Posva
LGTM -ip
6 years, 1 month ago (2014-11-14 21:43:22 UTC) #2
koda
6 years, 1 month ago (2014-11-15 01:29:53 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as r41756 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698