Issue 71373005: Fix bug with deoptimization targets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 71373005: Fix bug with deoptimization targets. (Closed)

Created:
7 years, 1 month ago by Florian Schneider

Modified:
7 years, 1 month ago

Reviewers:
srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Fix bug with deoptimization targets. In the second pass of inserting representation conversions (SelectRepresentations) we may insert sequences of Unbox/Box instructions that are eliminated by canonicalization later. However, inserting conversions requires a deoptimization id as deoptimization target. Return kNoDeoptId for Box-instructions since they don't need a real deoptimization target. BUG=dartbug.com/14808 R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=30234

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	runtime/vm/intermediate_language.h	View		4 chunks	+16 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

7 years, 1 month ago (2013-11-13 16:23:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r30234 (presubmit successful).

Expand Messages | Collapse Messages