Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Issue 712603002: Add more double-parsing tests. (Closed)

Created:
6 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
6 years, 1 month ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add more double-parsing tests. I was looking at double parsing, and wanted more tests for myself anyway. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=41664

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+924 lines, -95 lines) Patch
M tests/corelib/double_parse_test.dart View 2 chunks +924 lines, -95 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Lasse Reichstein Nielsen
They all pass, so that's good.
6 years, 1 month ago (2014-11-07 14:59:03 UTC) #2
Lasse Reichstein Nielsen
ping
6 years, 1 month ago (2014-11-11 07:52:05 UTC) #3
floitsch
LGTM.
6 years, 1 month ago (2014-11-11 09:26:35 UTC) #4
Lasse Reichstein Nielsen
6 years, 1 month ago (2014-11-11 13:31:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r41664 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698