Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(506)

Issue 712313005: Moves BUILD.gn config from root to runtime. (Closed)

Created:
6 years, 1 month ago by zra
Modified:
6 years, 1 month ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Moves BUILD.gn config from root to runtime. Cannot checkout a single file from svn through gclient. Committed: https://code.google.com/p/dart/source/detail?r=41677

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -39 lines) Patch
D BUILD.gn View 1 chunk +0 lines, -28 lines 0 comments Download
M runtime/BUILD.gn View 1 chunk +26 lines, -1 line 0 comments Download
M runtime/bin/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/third_party/double-conversion/src/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M runtime/third_party/jscre/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/BUILD.gn View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
zra
6 years, 1 month ago (2014-11-11 22:27:30 UTC) #2
zra
Committed patchset #1 (id:1) manually as r41677 (presubmit successful).
6 years, 1 month ago (2014-11-11 22:59:06 UTC) #3
Ivan Posva
6 years, 1 month ago (2014-11-12 20:14:55 UTC) #4
Message was sent while issue was closed.
LGTM -ip

Powered by Google App Engine
This is Rietveld 408576698