Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 712313004: Fix AccessSemantics for function typedefs and "dynamic". (Closed)

Created:
6 years, 1 month ago by Paul Berry
Modified:
6 years, 1 month ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix AccessSemantics for function typedefs and "dynamic". R=johnniwinther@google.com, scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -12 lines) Patch
M pkg/analyzer2dart/lib/src/identifier_semantics.dart View 4 chunks +13 lines, -9 lines 0 comments Download
M pkg/analyzer2dart/lib/src/semantic_visitor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer2dart/test/identifier_semantics_test.dart View 2 chunks +57 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Paul Berry
6 years, 1 month ago (2014-11-11 13:59:47 UTC) #2
Johnni Winther
lgtm
6 years, 1 month ago (2014-11-11 15:07:42 UTC) #3
scheglov
LGTM
6 years, 1 month ago (2014-11-11 15:47:29 UTC) #4
Paul Berry
6 years, 1 month ago (2014-11-11 16:48:14 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41669 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698