Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 712083003: Create fewer unnecessary lists (Closed)

Created:
6 years, 1 month ago by Brian Wilkerson
Modified:
6 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2989 lines, -2871 lines) Patch
M pkg/analyzer/lib/src/generated/ast.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 34 chunks +38 lines, -33 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element_resolver.dart View 5 chunks +9 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 8 chunks +13 lines, -13 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 7 chunks +11 lines, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 55 chunks +66 lines, -66 lines 0 comments Download
M pkg/analyzer/lib/src/generated/html.dart View 2 chunks +6 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/java_core.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 98 chunks +183 lines, -193 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 38 chunks +54 lines, -63 lines 0 comments Download
M pkg/analyzer/lib/src/generated/scanner.dart View 8 chunks +9 lines, -9 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/ast_factory.dart View 18 chunks +249 lines, -114 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/element_factory.dart View 7 chunks +66 lines, -49 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/html_factory.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/all_the_rest.dart View 86 chunks +151 lines, -173 lines 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 70 chunks +241 lines, -216 lines 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 182 chunks +434 lines, -434 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 12 chunks +22 lines, -28 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 6 chunks +7 lines, -7 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 216 chunks +517 lines, -519 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 178 chunks +535 lines, -524 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/utilities_test.dart View 140 chunks +362 lines, -401 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
6 years, 1 month ago (2014-11-10 16:18:41 UTC) #2
scheglov
LGTM
6 years, 1 month ago (2014-11-10 17:19:59 UTC) #3
Brian Wilkerson
6 years, 1 month ago (2014-11-10 17:26:22 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 41641 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698