Issue 711833002: Support verified heap pointer writes on ia32.

Issue 711833002: Support verified heap pointer writes on ia32. (Closed)

Created:
6 years, 1 month ago by koda

Modified:
6 years, 1 month ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Support verified heap pointer writes on ia32. With --verified_mem, use VerifiedMemory to duplicate all pointer writes in the heap, and verify that no unaccounted writes occurred. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=41700

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 2

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+144 lines, -43 lines)			Patch
M	runtime/vm/assembler_ia32.h	View	1 2	2 chunks	+5 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_ia32.cc	View	1 2 3 4 5	7 chunks	+71 lines, -10 lines	2 comments	Download
M	runtime/vm/code_patcher.h	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	runtime/vm/code_patcher_ia32.cc	View		3 chunks	+2 lines, -9 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1	2 chunks	+7 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3 4 5	1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intrinsifier_ia32.cc	View	1 2 3 4	5 chunks	+9 lines, -7 lines	0 comments	Download
M	runtime/vm/object.h	View		3 chunks	+2 lines, -4 lines	0 comments	Download
M	runtime/vm/object.cc	View		5 chunks	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/pages.cc	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	runtime/vm/raw_object.h	View	1 2	3 chunks	+4 lines, -3 lines	0 comments	Download
M	runtime/vm/scavenger.cc	View		5 chunks	+5 lines, -2 lines	0 comments	Download
M	runtime/vm/snapshot.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/verified_memory.h	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/verifier.cc	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/standalone/standalone.status	View	1 2 3	1 chunk	+2 lines, -0 lines	0 comments	Download
A	tests/standalone/verified_mem_test.dart	View	1 2 3 4 5	1 chunk	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

koda

Updated w/ fix for DeltaBlue (inline array alloc, see https://code.google.com/p/dart/issues/detail?id=21570 ) PTAL

6 years, 1 month ago (2014-11-11 17:08:38 UTC) #2

koda

On 2014/11/11 17:08:38, koda wrote: > Updated w/ fix for DeltaBlue (inline array alloc, see ...

6 years, 1 month ago (2014-11-12 00:13:01 UTC) #3

Ivan Posva

LGTM -ip https://codereview.chromium.org/711833002/diff/90001/runtime/vm/assembler_ia32.cc File runtime/vm/assembler_ia32.cc (right): https://codereview.chromium.org/711833002/diff/90001/runtime/vm/assembler_ia32.cc#newcode2312 runtime/vm/assembler_ia32.cc:2312: Immediate zero(Smi::RawValue(0)); Add TODO

6 years, 1 month ago (2014-11-12 21:22:49 UTC) #4

koda

https://codereview.chromium.org/711833002/diff/90001/runtime/vm/assembler_ia32.cc File runtime/vm/assembler_ia32.cc (right): https://codereview.chromium.org/711833002/diff/90001/runtime/vm/assembler_ia32.cc#newcode2312 runtime/vm/assembler_ia32.cc:2312: Immediate zero(Smi::RawValue(0)); On 2014/11/12 21:22:49, Ivan Posva wrote: > ...

6 years, 1 month ago (2014-11-12 23:47:30 UTC) #5

koda

6 years, 1 month ago (2014-11-12 23:47:53 UTC) #6

Message was sent while issue was closed.

Committed patchset #6 (id:90001) manually as r41700 (presubmit successful).

Expand Messages | Collapse Messages