Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(529)

Issue 711533003: first cut argument list completion suggestions (Closed)

Created:
6 years, 1 month ago by danrubel
Modified:
6 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

first cut argument list completion suggestions - first cut simplistic insertion of params - required params only for now - move cursor after ) if no params - don't insert () if identifier suggestion - does not cover all method/function invocations yet - updated comments in Server API - extracted new declaration visitor BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41586

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+945 lines, -358 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/generated/types/CompletionSuggestionKind.java View 1 chunk +5 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/internal/text/dart/DartServerProposal.java View 4 chunks +13 lines, -2 lines 0 comments Download
M pkg/analysis_server/doc/api.html View 1 chunk +9 lines, -1 line 0 comments Download
M pkg/analysis_server/lib/src/generated_protocol.dart View 1 chunk +6 lines, -0 lines 0 comments Download
A pkg/analysis_server/lib/src/services/completion/arglist_computer.dart View 1 chunk +216 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/local_computer.dart View 7 chunks +166 lines, -324 lines 0 comments Download
A pkg/analysis_server/lib/src/services/completion/local_declaration_visitor.dart View 1 chunk +229 lines, -0 lines 0 comments Download
A pkg/analysis_server/test/services/completion/arglist_computer_test.dart View 1 chunk +117 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 6 chunks +173 lines, -30 lines 0 comments Download
M pkg/analysis_server/test/services/completion/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download
M pkg/analysis_server/tool/spec/spec_input.html View 1 chunk +9 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
6 years, 1 month ago (2014-11-06 21:18:34 UTC) #2
scheglov
lgtm
6 years, 1 month ago (2014-11-06 21:37:57 UTC) #3
danrubel
6 years, 1 month ago (2014-11-06 21:42:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41586 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698