Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 711303002: Fix try/poi/serialize_test after adding class to dart:core. (Closed)

Created:
6 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
6 years, 1 month ago
Reviewers:
ricow1, ahe
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Fix try/poi/serialize_test after adding class to dart:core. Committed: https://code.google.com/p/dart/source/detail?r=41655

Patch Set 1 #

Patch Set 2 : No pubspec. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tests/try/poi/serialize_test.dart View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Lasse Reichstein Nielsen
TBR
6 years, 1 month ago (2014-11-11 09:02:33 UTC) #2
Lasse Reichstein Nielsen
Committed patchset #2 manually as r41655 (presubmit successful).
6 years, 1 month ago (2014-11-11 09:02:54 UTC) #3
ricow1
Move ahe@ to reviewer, move me to cc, I don't know anything about this
6 years, 1 month ago (2014-11-11 09:04:28 UTC) #5
ahe
LGTM Don't forget to announce this breaking change.
6 years, 1 month ago (2014-11-11 09:14:47 UTC) #6
Lasse Reichstein Nielsen
On 2014/11/11 09:14:47, ahe wrote: > LGTM > > Don't forget to announce this breaking ...
6 years, 1 month ago (2014-11-11 09:24:48 UTC) #7
ahe
6 years, 1 month ago (2014-11-11 09:29:50 UTC) #8
Message was sent while issue was closed.
On 2014/11/11 09:24:48, Lasse Reichstein Nielsen wrote:
> On 2014/11/11 09:14:47, ahe wrote:
> > LGTM
> > 
> > Don't forget to announce this breaking change.
> 
> Ack, will do.
> 
> It should only be breaking if you depend on the exact toString of a
RangeError,
> or if you use runtimeType. I don't think we have generally guaranteed to not
> change the runtimeType.

Also, if you have something like this:

class SuperInLibraryA {
  IndexError() { // Yeah, I'm not following the Dart style guide.
  }
}

class ClassInLibraryB extends SuperInLibraryA {
  m() => IndexError();
}

Regardless, I question the reasoning behind adding more exception/error classes
to dart:core. They serve exactly no purpose and only make more co19 tests, and
make dart2js output larger.

Powered by Google App Engine
This is Rietveld 408576698