Issue 710653002: Simplify type propagation and IL declarations of TemplateInstruction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 710653002: Simplify type propagation and IL declarations of TemplateInstruction. (Closed)

Created:
6 years, 1 month ago by Florian Schneider

Modified:
6 years, 1 month ago

Reviewers:
Vyacheslav Egorov (Google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Simplify type propagation and IL declarations of TemplateInstruction. Replace ComputeInitialType. It is not needed anymore. AssertAssignable now properly uses the cid of the incoming value-type in its compile-type. ArgumentCount is has now a default implementation that returns 0 to avoid defining it on all subclasses of TemplateInstruction (TemplateDefinition already had it defined) R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41602

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -70 lines)			Patch
	M	runtime/vm/flow_graph_type_propagator.cc	View		8 chunks	+9 lines, -28 lines	0 comments	Download
	M	runtime/vm/intermediate_language.h	View		22 chunks	+4 lines, -42 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Florian Schneider

6 years, 1 month ago (2014-11-07 13:07:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r41602 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages