Check enums in switch cases.

Check enums in switch cases.

BUG=
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41796

[Johnni Winther, 2014-11-11 15:15:04]

johnniwinther@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2014-11-12 17:52:35]

LGTM.

https://codereview.chromium.org/710343002/diff/1/pkg/compiler/lib/src/element...
File pkg/compiler/lib/src/elements/elements.dart (right):

https://codereview.chromium.org/710343002/diff/1/pkg/compiler/lib/src/element...
pkg/compiler/lib/src/elements/elements.dart:1419: /// The static field implied
by the enum values.
static fields

https://codereview.chromium.org/710343002/diff/1/pkg/compiler/lib/src/typeche...
File pkg/compiler/lib/src/typechecker.dart (right):

https://codereview.chromium.org/710343002/diff/1/pkg/compiler/lib/src/typeche...
pkg/compiler/lib/src/typechecker.dart:1782:
enumValues.remove(caseConstant.value);
Do you want to add a check here to make sure that the same enum is not
referenced multiple times?

[Johnni Winther, 2014-11-13 08:48:40]

https://codereview.chromium.org/710343002/diff/1/pkg/compiler/lib/src/element...
File pkg/compiler/lib/src/elements/elements.dart (right):

https://codereview.chromium.org/710343002/diff/1/pkg/compiler/lib/src/element...
pkg/compiler/lib/src/elements/elements.dart:1419: /// The static field implied
by the enum values.
On 2014/11/12 17:52:35, floitsch wrote:
> static fields

Done.

https://codereview.chromium.org/710343002/diff/1/pkg/compiler/lib/src/typeche...
File pkg/compiler/lib/src/typechecker.dart (right):

https://codereview.chromium.org/710343002/diff/1/pkg/compiler/lib/src/typeche...
pkg/compiler/lib/src/typechecker.dart:1782:
enumValues.remove(caseConstant.value);
On 2014/11/12 17:52:35, floitsch wrote:
> Do you want to add a check here to make sure that the same enum is not
> referenced multiple times?

Not required by spec but should have a hint regardless of whether the case
expressions are enum or regular constants. Adding a TODO.

[Johnni Winther, 2014-11-13 09:50:34]

PTAL at the latest patch. I had to make to whole checking deferred to compute
the right constant values in face of redirecting factory constructors.

[Johnni Winther, 2014-11-17 09:20:15]

ping

[floitsch, 2014-11-17 13:31:13]

LGTM.

https://codereview.chromium.org/710343002/diff/40001/pkg/compiler/lib/src/ele...
File pkg/compiler/lib/src/elements/modelx.dart (right):

https://codereview.chromium.org/710343002/diff/40001/pkg/compiler/lib/src/ele...
pkg/compiler/lib/src/elements/modelx.dart:2423: Iterable<FieldElement>
enumValuesCache;
private?
maybe even _enumValues
That's the most common strategy for getters/setters.

[Johnni Winther, 2014-11-18 09:44:20]

https://codereview.chromium.org/710343002/diff/40001/pkg/compiler/lib/src/ele...
File pkg/compiler/lib/src/elements/modelx.dart (right):

https://codereview.chromium.org/710343002/diff/40001/pkg/compiler/lib/src/ele...
pkg/compiler/lib/src/elements/modelx.dart:2423: Iterable<FieldElement>
enumValuesCache;
On 2014/11/17 13:31:12, floitsch wrote:
> private?
> maybe even _enumValues
> That's the most common strategy for getters/setters.

Done.

[Johnni Winther, 2014-11-18 10:10:34]

Committed patchset #4 (id:60001) manually as 41796 (presubmit successful).