Issue 710283002: Improve Expect.stringEquals output.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 710283002: Improve Expect.stringEquals output. (Closed)

Created:
6 years, 1 month ago by Lasse Reichstein Nielsen

Modified:
6 years, 1 month ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Change Expect.stringEquals to give more information about the difference, so it's possible to find it in a long string. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=41656

Patch Set 1 #

Patch Set 2 : Add more documentation #

Total comments: 2

Patch Set 3 : Make this just the Expect change #

Patch Set 4 : Address comments. #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+51 lines, -38 lines)			Patch
	M	pkg/expect/lib/expect.dart	View	1 2 3	2 chunks	+50 lines, -37 lines	0 comments	Download
	M	pkg/expect/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ricow1

lgtm https://codereview.chromium.org/710283002/diff/20001/pkg/expect/lib/expect.dart File pkg/expect/lib/expect.dart (right): https://codereview.chromium.org/710283002/diff/20001/pkg/expect/lib/expect.dart#newcode294 pkg/expect/lib/expect.dart:294: // If snippets long, elide the middle. if ...

6 years, 1 month ago (2014-11-11 09:10:39 UTC) #3

Lasse Reichstein Nielsen

6 years, 1 month ago (2014-11-11 09:16:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #4 manually as r41656 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages