Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 710173005: Disable source maps completely. (Closed)

Created:
6 years, 1 month ago by ahe
Modified:
6 years, 1 month ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, kasperl, lukechurch, sigurdm, floitsch
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Merged with r41761. #

Patch Set 3 : Update fallbackCompiler to new API. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -8 lines) Patch
M dart/pkg/compiler/lib/src/js_backend/backend.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M dart/pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M dart/pkg/compiler/lib/src/ssa/builder.dart View 1 6 chunks +10 lines, -6 lines 0 comments Download
M dart/tests/try/web/incremental_compilation_update_test.dart View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
ahe
During incremental compilation, source maps are disabled using the compiler option --no-source-maps. This is a ...
6 years, 1 month ago (2014-11-11 14:10:40 UTC) #2
Johnni Winther
lgtm
6 years, 1 month ago (2014-11-14 12:24:25 UTC) #3
ahe
Had to make a few tweaks as Sigurd added new abstractions in the backend.
6 years, 1 month ago (2014-11-17 08:12:58 UTC) #4
ahe
Committed patchset #3 (id:40001) manually as 41768 (presubmit successful).
6 years, 1 month ago (2014-11-17 09:55:31 UTC) #5
Johnni Winther
6 years, 1 month ago (2014-11-19 12:19:52 UTC) #6
Message was sent while issue was closed.
Still lgtm

Powered by Google App Engine
This is Rietveld 408576698