Adds extra validation to code collection test.

Adds extra validation to code collection test.

R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41644

[zra, 2014-11-10 16:23:58]

zra@google.com changed reviewers:
+ iposva@google.com

[Ivan Posva, 2014-11-10 16:47:34]

https://codereview.chromium.org/710093002/diff/20001/tests/standalone/io/code...
File tests/standalone/io/code_collection_test.dart (right):

https://codereview.chromium.org/710093002/diff/20001/tests/standalone/io/code...
tests/standalone/io/code_collection_test.dart:76: Expect.equals(3, count);
This test does not ensure that the code was detached first before the next calls
to foo().

[zra, 2014-11-10 16:52:13]

https://codereview.chromium.org/710093002/diff/20001/tests/standalone/io/code...
File tests/standalone/io/code_collection_test.dart (right):

https://codereview.chromium.org/710093002/diff/20001/tests/standalone/io/code...
tests/standalone/io/code_collection_test.dart:76: Expect.equals(3, count);
On 2014/11/10 16:47:33, Ivan Posva wrote:
> This test does not ensure that the code was detached first before the next
calls
> to foo().

Acknowledged.

[zra, 2014-11-10 16:52:46]

On 2014/11/10 16:52:13, zra wrote:
>
https://codereview.chromium.org/710093002/diff/20001/tests/standalone/io/code...
> File tests/standalone/io/code_collection_test.dart (right):
> 
>
https://codereview.chromium.org/710093002/diff/20001/tests/standalone/io/code...
> tests/standalone/io/code_collection_test.dart:76: Expect.equals(3, count);
> On 2014/11/10 16:47:33, Ivan Posva wrote:
> > This test does not ensure that the code was detached first before the next
> calls
> > to foo().
> 
> Acknowledged.

Added more asserts.

[Ivan Posva, 2014-11-10 17:19:32]

LGTM after verifying manually (once!)that it would crash if we had an error in
patching the code when collecting.

-Ivan

[zra, 2014-11-10 19:14:05]

On 2014/11/10 17:19:32, Ivan Posva wrote:
> LGTM after verifying manually (once!)that it would crash if we had an error in
> patching the code when collecting.
> 
> -Ivan

Verified crashing with dummy value for instructions instead of lazy compile
stub.

[zra, 2014-11-10 19:15:29]

Committed patchset #3 (id:40001) manually as r41644 (presubmit successful).