Issue 70993002: - Convert heap sizes to words from bytes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 70993002: - Convert heap sizes to words from bytes. (Closed)

Created:
7 years, 1 month ago by Ivan Posva

Modified:
7 years, 1 month ago

Reviewers:
siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Patch Set 3 : #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -24 lines)			Patch
M	runtime/vm/find_code_object_test.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/pages.h	View	1 2	4 chunks	+4 lines, -6 lines	0 comments	Download
M	runtime/vm/pages.cc	View	1 2	6 chunks	+19 lines, -17 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

siva

LGTM with one comment. https://codereview.chromium.org/70993002/diff/110001/runtime/vm/pages.cc File runtime/vm/pages.cc (right): https://codereview.chromium.org/70993002/diff/110001/runtime/vm/pages.cc#newcode152 runtime/vm/pages.cc:152: capacity_in_words_ += (kPageSize >> kWordSizeLog2); ...

7 years, 1 month ago (2013-11-15 22:06:22 UTC) #2

Ivan Posva

7 years, 1 month ago (2013-11-16 00:16:57 UTC) #3

Similar code for other areas of the VM to follow shortly...

-Ivan

https://codereview.chromium.org/70993002/diff/110001/runtime/vm/pages.cc
File runtime/vm/pages.cc (right):

https://codereview.chromium.org/70993002/diff/110001/runtime/vm/pages.cc#newc...
runtime/vm/pages.cc:158: HeapPage* PageSpace::AllocateLargePage(intptr_t size,
HeapPage::PageType type) {
On 2013/11/15 22:06:22, siva wrote:
> Why is this size not in words? It is confusing that capacity is in words but
> size is in bytes.

HeapPage has not been updated yet.

Expand Messages | Collapse Messages

Issue 70993002: - Convert heap sizes to words from bytes. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages