Fixes issue 14742. Dart API may allocate objects without calling the constructor, this messes up th…

Fixes issue 14742. Dart API may allocate objects without calling the constructor, this messes up the nullability tracking in the VM. Simple fix for now: initialize fields nullability, type, length if allocated via Dart API.

R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30233

[siva, 2013-11-13 15:33:13]

LGTM.

Maybe as an optimization we could see if a flag can be set in the class so that
we don't do this iteration on every allocation.

[Florian Schneider, 2013-11-13 15:37:27]

dbc: What is the reason not to go through the constructor in this case?

[siva, 2013-11-13 15:39:29]

The dartium bindings guys did not want to invoke the constructor, I believe it
has something to do with custom bindings. I can get a clearer answer today and
post back to this review.

[srdjan, 2013-11-13 16:01:47]

Committed patchset #2 manually as r30233 (presubmit successful).

[srdjan, 2013-11-13 16:11:49]

On 2013/11/13 15:33:13, siva wrote:
> LGTM.
> 
> Maybe as an optimization we could see if a flag can be set in the class so
that
> we don't do this iteration on every allocation.

Submitted as is, let's see if we can see any performance degradation.

[siva, 2013-11-13 19:22:17]

Vijay has updated the bug
(https://code.google.com/p/dart/issues/detail?id=14742)
with some context on why dartium does not invoke the constructors.