Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 709603003: Add compile-time errors for enums. (Closed)

Created:
6 years, 1 month ago by Johnni Winther
Modified:
6 years, 1 month ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add compile-time errors for enums. BUG= R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=41663

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -4 lines) Patch
M pkg/compiler/lib/src/dart_types.dart View 2 chunks +5 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 5 chunks +26 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/warnings.dart View 1 chunk +44 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/resolver_test.dart View 5 chunks +30 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
6 years, 1 month ago (2014-11-11 10:35:16 UTC) #2
floitsch
LGTM.
6 years, 1 month ago (2014-11-11 10:40:04 UTC) #3
Johnni Winther
6 years, 1 month ago (2014-11-11 12:59:51 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41663 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698