Issue 709493002: Fix 'Unused local variable' hints in analyzer and analysis_server.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 709493002: Fix 'Unused local variable' hints in analyzer and analysis_server. (Closed)

Created:
6 years, 1 month ago by scheglov

Modified:
6 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix 'Unused local variable' hints in analyzer and analysis_server. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41576

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -46 lines)			Patch
M	pkg/analysis_server/lib/src/domain_execution.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/lib/src/edit/edit_domain.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/correction/fix_internal.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/analysis/notification_outline_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/domain_completion_test.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/domain_execution_test.dart	View	2 chunks	+1 line, -2 lines	0 comments	Download
M	pkg/analysis_server/test/edit/refactoring_test.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/integration/integration_tests.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/correction/change_test.dart	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/services/correction/fix_test.dart	View	2 chunks	+0 lines, -2 lines	0 comments	Download
M	pkg/analysis_server/test/services/correction/source_range_test.dart	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/test/services/index/dart_index_contributor_test.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/index/store/split_store_test.dart	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/test/services/refactoring/move_file_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/search/hierarchy_test.dart	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/test/services/search/search_engine_test.dart	View	4 chunks	+2 lines, -7 lines	0 comments	Download
M	pkg/analysis_server/test/timing/timing_framework.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analysis_server/tool/spec/codegen_java_types.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analyzer/bin/analyzer.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/bin/formatter.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/services/formatter_impl.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/services/writer.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	pkg/analyzer/test/file_system/memory_file_system_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/test/generated/ast_test.dart	View	3 chunks	+3 lines, -5 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

6 years, 1 month ago (2014-11-06 18:33:12 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 41576 (presubmit successful).

Expand Messages | Collapse Messages