Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 708993003: Revert "Revert "dart2js: Add a type parameter to class Reference...."" (Closed)

Created:
6 years, 1 month ago by Kevin Millikin (Google)
Modified:
6 years, 1 month ago
Reviewers:
sigurdm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Revert "dart2js: Add a type parameter to class Reference...."" This reapplies svn commit r41564, with fixes to the dart2js intermediate representation (IR) tests. The tests explicitly construct IR expressions and so need to be updated. Some of the tests are currently invalid expressions, which have been removed. BUG= R=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=41603

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -154 lines) Patch
M pkg/analyzer2dart/lib/src/cps_generator.dart View 5 chunks +7 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/constant_propagation.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 12 chunks +17 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 21 chunks +57 lines, -57 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/opt_redundant_phi_test.dart View 3 chunks +3 lines, -29 lines 0 comments Download
M tests/compiler/dart2js/backend_dart/opt_shrinking_test.dart View 5 chunks +12 lines, -24 lines 1 comment Download
M tests/compiler/dart2js/backend_dart/sexpr_unstringifier.dart View 7 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Kevin Millikin (Google)
The new changes are in tests/compiler. The rest of the code is unchanged.
6 years, 1 month ago (2014-11-07 11:56:20 UTC) #2
Kevin Millikin (Google)
https://codereview.chromium.org/708993003/diff/1/tests/compiler/dart2js/backend_dart/opt_shrinking_test.dart File tests/compiler/dart2js/backend_dart/opt_shrinking_test.dart (left): https://codereview.chromium.org/708993003/diff/1/tests/compiler/dart2js/backend_dart/opt_shrinking_test.dart#oldcode174 tests/compiler/dart2js/backend_dart/opt_shrinking_test.dart:174: (InvokeContinuation k0 v4)) v4 is not in scope here. ...
6 years, 1 month ago (2014-11-07 11:58:54 UTC) #3
sigurdm
lgtm
6 years, 1 month ago (2014-11-07 12:14:59 UTC) #4
Kevin Millikin (Google)
6 years, 1 month ago (2014-11-07 13:22:04 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as 41603 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698