Support enums in dart2js.

Support enums in dart2js.

- still missing warnings/errors.

BUG=https://code.google.com/p/dart/issues/detail?id=21417
R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41654

[Johnni Winther, 2014-11-09 15:08:52]

johnniwinther@google.com changed reviewers:
+ floitsch@google.com

[floitsch, 2014-11-10 16:08:32]

LGTM.

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/element...
File pkg/compiler/lib/src/elements/modelx.dart (right):

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/element...
pkg/compiler/lib/src/elements/modelx.dart:2439: accept(ElementVisitor visitor)
=> visitor.visitClassElement(this);
Why don't we need visitor.visitEnumClass ?

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/element...
pkg/compiler/lib/src/elements/modelx.dart:2450: : super('',
'',  // Name.

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/resolut...
File pkg/compiler/lib/src/resolution/enum_creator.dart (right):

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/resolut...
pkg/compiler/lib/src/resolution/enum_creator.dart:23: Modifiers finalModifiers =
final

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/resolut...
pkg/compiler/lib/src/resolution/enum_creator.dart:86: null,
comment, what this one is.

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/resolut...
pkg/compiler/lib/src/resolution/enum_creator.dart:91: EmptyStatement get
emptyStatement => new EmptyStatement(symbolToken(COMMA_INFO));
long line.

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/resolut...
pkg/compiler/lib/src/resolution/enum_creator.dart:186: constructor,
nameDefinition,
keep nameDefinition on its own line.

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/resolut...
pkg/compiler/lib/src/resolution/enum_creator.dart:192: const Link<Element>(),
what are all these arguments?

either add comments, make them named, or assign to variables (with useful name)
first.

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/resolut...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/resolut...
pkg/compiler/lib/src/resolution/members.dart:4351: // Setup the supertype for
the element (if there is a cycle in the
That comment should not be necessary.
Enums only have Object as superclass.

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/resolut...
pkg/compiler/lib/src/resolution/members.dart:4354: // Avoid making the
superclass (usually Object) extend itself.
ditto.

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/resolut...
pkg/compiler/lib/src/resolution/members.dart:4355: if (element != superElement)
{
These tests should just be replaced with an invariant that the superclass is
Object.

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/resolut...
File pkg/compiler/lib/src/resolution/resolution.dart (right):

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/resolut...
pkg/compiler/lib/src/resolution/resolution.dart:45: import 'enum_Creator.dart';
no upper-case in file names.

[Johnni Winther, 2014-11-11 08:23:37]

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/element...
File pkg/compiler/lib/src/elements/modelx.dart (right):

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/element...
pkg/compiler/lib/src/elements/modelx.dart:2439: accept(ElementVisitor visitor)
=> visitor.visitClassElement(this);
On 2014/11/10 16:08:32, floitsch wrote:
> Why don't we need visitor.visitEnumClass ?

Because there is no EnumClassElement interface.

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/element...
pkg/compiler/lib/src/elements/modelx.dart:2450: : super('',
On 2014/11/10 16:08:32, floitsch wrote:
> '',  // Name.

Done.

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/resolut...
File pkg/compiler/lib/src/resolution/enum_creator.dart (right):

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/resolut...
pkg/compiler/lib/src/resolution/enum_creator.dart:23: Modifiers finalModifiers =
On 2014/11/10 16:08:32, floitsch wrote:
> final

Done.

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/resolut...
pkg/compiler/lib/src/resolution/enum_creator.dart:86: null,
On 2014/11/10 16:08:32, floitsch wrote:
> comment, what this one is.

Done.

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/resolut...
pkg/compiler/lib/src/resolution/enum_creator.dart:91: EmptyStatement get
emptyStatement => new EmptyStatement(symbolToken(COMMA_INFO));
On 2014/11/10 16:08:32, floitsch wrote:
> long line.

Done.

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/resolut...
pkg/compiler/lib/src/resolution/enum_creator.dart:186: constructor,
nameDefinition,
On 2014/11/10 16:08:32, floitsch wrote:
> keep nameDefinition on its own line.

Done.

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/resolut...
pkg/compiler/lib/src/resolution/enum_creator.dart:192: const Link<Element>(),
On 2014/11/10 16:08:32, floitsch wrote:
> what are all these arguments?
> 
> either add comments, make them named, or assign to variables (with useful
name)
> first.

Changed the constructor of FunctionSignatureX to take named arguments.

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/resolut...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/resolut...
pkg/compiler/lib/src/resolution/members.dart:4351: // Setup the supertype for
the element (if there is a cycle in the
On 2014/11/10 16:08:32, floitsch wrote:
> That comment should not be necessary.
> Enums only have Object as superclass.

Reduced to setting the supertype to Object.

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/resolut...
File pkg/compiler/lib/src/resolution/resolution.dart (right):

https://codereview.chromium.org/707463003/diff/1/pkg/compiler/lib/src/resolut...
pkg/compiler/lib/src/resolution/resolution.dart:45: import 'enum_Creator.dart';
On 2014/11/10 16:08:32, floitsch wrote:
> no upper-case in file names.

On Windows, maybe ;-)

[Johnni Winther, 2014-11-11 08:29:21]

Committed patchset #2 (id:20001) manually as 41654 (presubmit successful).