Add a Peer class to json_rpc_2.

Add a Peer class to json_rpc_2.

R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41680

[Bob Nystrom, 2014-11-07 17:41:51]

https://codereview.chromium.org/707063002/diff/1/pkg/json_rpc_2/lib/src/peer....
File pkg/json_rpc_2/lib/src/peer.dart (right):

https://codereview.chromium.org/707063002/diff/1/pkg/json_rpc_2/lib/src/peer....
pkg/json_rpc_2/lib/src/peer.dart:32: /// A stream controller that forwards
incomping messages to [_server] if
"incoming", here and below.

Also, referencing a private member in a public member's doc comment fields weird
to me. How about "[_server]" -> "the server"?

https://codereview.chromium.org/707063002/diff/1/pkg/json_rpc_2/lib/src/peer....
pkg/json_rpc_2/lib/src/peer.dart:120: if (message.first.containsKey('result') ||
What if message.first isn't a Map?

https://codereview.chromium.org/707063002/diff/1/pkg/json_rpc_2/test/peer_tes...
File pkg/json_rpc_2/test/peer_test.dart (right):

https://codereview.chromium.org/707063002/diff/1/pkg/json_rpc_2/test/peer_tes...
pkg/json_rpc_2/test/peer_test.dart:23: peer = new
json_rpc.Peer.withoutJson(incomingController.stream, outgoingController);
Long line. More below.

[nweiz, 2014-11-10 21:45:04]

Code review changes

[nweiz, 2014-11-10 21:45:31]

https://codereview.chromium.org/707063002/diff/1/pkg/json_rpc_2/lib/src/peer....
File pkg/json_rpc_2/lib/src/peer.dart (right):

https://codereview.chromium.org/707063002/diff/1/pkg/json_rpc_2/lib/src/peer....
pkg/json_rpc_2/lib/src/peer.dart:32: /// A stream controller that forwards
incomping messages to [_server] if
On 2014/11/07 17:41:51, Bob Nystrom wrote:
> "incoming", here and below.

Done.

> Also, referencing a private member in a public member's doc comment fields
weird
> to me. How about "[_server]" -> "the server"?

These should actually just be private.

https://codereview.chromium.org/707063002/diff/1/pkg/json_rpc_2/lib/src/peer....
pkg/json_rpc_2/lib/src/peer.dart:120: if (message.first.containsKey('result') ||
On 2014/11/07 17:41:51, Bob Nystrom wrote:
> What if message.first isn't a Map?

Done.

https://codereview.chromium.org/707063002/diff/1/pkg/json_rpc_2/test/peer_tes...
File pkg/json_rpc_2/test/peer_test.dart (right):

https://codereview.chromium.org/707063002/diff/1/pkg/json_rpc_2/test/peer_tes...
pkg/json_rpc_2/test/peer_test.dart:23: peer = new
json_rpc.Peer.withoutJson(incomingController.stream, outgoingController);
On 2014/11/07 17:41:51, Bob Nystrom wrote:
> Long line. More below.

Done.

[Bob Nystrom, 2014-11-10 21:49:20]

lgtm

[nweiz, 2014-11-11 23:10:47]

Committed patchset #2 (id:20001) manually as 41680 (presubmit successful).