Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 706823003: Clean up error codes implementation (Closed)

Created:
6 years, 1 month ago by Brian Wilkerson
Modified:
6 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1834 lines, -2082 lines) Patch
M pkg/analyzer/lib/src/generated/error.dart View 7 chunks +1834 lines, -2028 lines 0 comments Download
M pkg/analyzer/test/enum_test.dart View 5 chunks +0 lines, -54 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
6 years, 1 month ago (2014-11-06 17:40:45 UTC) #2
scheglov
LGTM
6 years, 1 month ago (2014-11-06 17:47:03 UTC) #3
Brian Wilkerson
6 years, 1 month ago (2014-11-06 17:55:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41574 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698