Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1138)

Issue 706793002: Remove/skip invalid mirror tests. (Closed)

Created:
6 years, 1 month ago by rmacnak
Modified:
6 years, 1 month ago
Reviewers:
floitsch, gbracha
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove/skip invalid mirror tests. -class of 1 is not required to declare int as an interface -owner of members of mixin applications is the mixin -MirrorsUsed does not have a semantics R=gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=41540

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -115 lines) Patch
M tests/lib/lib.status View 3 chunks +5 lines, -11 lines 0 comments Download
D tests/lib/mirrors/hierarchy_test.dart View 1 chunk +0 lines, -55 lines 0 comments Download
M tests/lib/mirrors/intercepted_object_test.dart View 1 1 chunk +6 lines, -0 lines 0 comments Download
A + tests/lib/mirrors/mirrors_used_typedef_declaration_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tests/lib/mirrors/mixin_application_test.dart View 11 chunks +0 lines, -14 lines 0 comments Download
D tests/lib/mirrors/typedef_declaration_test.dart View 1 chunk +0 lines, -29 lines 0 comments Download
M tests/lib/mirrors/typedef_test.dart View 1 chunk +1 line, -7 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
rmacnak
6 years, 1 month ago (2014-11-06 00:31:28 UTC) #2
gbracha
I am ok with these changes (one minor comment) but you should be sure that ...
6 years, 1 month ago (2014-11-06 00:51:17 UTC) #3
rmacnak
On 2014/11/06 00:51:17, gbracha wrote: > I am ok with these changes (one minor comment) ...
6 years, 1 month ago (2014-11-06 01:02:44 UTC) #4
rmacnak
https://codereview.chromium.org/706793002/diff/1/tests/lib/mirrors/intercepted_object_test.dart File tests/lib/mirrors/intercepted_object_test.dart (right): https://codereview.chromium.org/706793002/diff/1/tests/lib/mirrors/intercepted_object_test.dart#newcode32 tests/lib/mirrors/intercepted_object_test.dart:32: } On 2014/11/06 00:51:17, gbracha wrote: > This just ...
6 years, 1 month ago (2014-11-06 01:02:49 UTC) #5
gbracha
lgtm
6 years, 1 month ago (2014-11-06 01:08:48 UTC) #6
rmacnak
Committed patchset #2 (id:10001) manually as 41540 (presubmit successful).
6 years, 1 month ago (2014-11-06 01:10:41 UTC) #7
floitsch
Why did you remove the typedef_declaration_test? It is testing something for dart2js.
6 years, 1 month ago (2014-11-06 12:54:42 UTC) #9
rmacnak
On 2014/11/06 12:54:42, floitsch wrote: > Why did you remove the typedef_declaration_test? > It is ...
6 years, 1 month ago (2014-11-06 17:51:04 UTC) #10
floitsch
6 years, 1 month ago (2014-11-07 10:03:24 UTC) #11
Message was sent while issue was closed.
On 2014/11/06 17:51:04, rmacnak wrote:
> On 2014/11/06 12:54:42, floitsch wrote:
> > Why did you remove the typedef_declaration_test?
> > It is testing something for dart2js.
> 
> It was renamed to mirrors_used_typedef_declaration_test, not removed.

Thanks! I don't know how I missed that.

Powered by Google App Engine
This is Rietveld 408576698