Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 706263003: Issue 20827. Add imports as needed the 'Add type annotation' Quick Assist. (Closed)

Created:
6 years, 1 month ago by scheglov
Modified:
6 years, 1 month ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Issue 20827. Add imports as needed the 'Add type annotation' Quick Assist. I left some TODOs, the CL is big enough already. R=paulberry@google.com BUG= https://code.google.com/p/dart/issues/detail?id=20827 Committed: https://code.google.com/p/dart/source/detail?r=41620

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+293 lines, -103 lines) Patch
M pkg/analysis_server/lib/src/services/correction/assist_internal.dart View 18 chunks +73 lines, -59 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 9 chunks +23 lines, -25 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/util.dart View 14 chunks +64 lines, -14 lines 0 comments Download
M pkg/analysis_server/lib/src/services/refactoring/extract_method.dart View 4 chunks +12 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/mock_sdk.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/correction/assist_test.dart View 3 chunks +120 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 1 month ago (2014-11-07 20:43:31 UTC) #1
Paul Berry
lgtm
6 years, 1 month ago (2014-11-07 21:39:38 UTC) #2
scheglov
6 years, 1 month ago (2014-11-07 23:21:42 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41620 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698