Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 706133002: Use a more compact internal representation for FileSpan. (Closed)

Created:
6 years, 1 month ago by nweiz
Modified:
6 years, 1 month ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use a more compact internal representation for FileSpan. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=41591

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -10 lines) Patch
M pkg/source_span/CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M pkg/source_span/lib/src/file.dart View 4 chunks +21 lines, -9 lines 0 comments Download
M pkg/source_span/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 1 month ago (2014-11-07 00:26:47 UTC) #1
Bob Nystrom
lgtm
6 years, 1 month ago (2014-11-07 00:30:44 UTC) #2
nweiz
6 years, 1 month ago (2014-11-07 00:31:07 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41591 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698