Issue 705713004: Add simpler unit tests for VerifiedMemory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 705713004: Add simpler unit tests for VerifiedMemory. (Closed)

Created:
6 years, 1 month ago by koda

Modified:
6 years, 1 month ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add simpler unit tests for VerifiedMemory. Also remember to free the reservation and the end of (non-negative) tests. BUG=21469 TBR=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=41528

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -0 lines)			Patch
	M	runtime/vm/verified_memory_test.cc	View		3 chunks	+21 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

koda

Committed patchset #1 (id:1) manually as r41528 (presubmit successful).

6 years, 1 month ago (2014-11-05 18:26:40 UTC) #1

Bill Hesse

6 years, 1 month ago (2014-11-06 08:41:56 UTC) #2

Message was sent while issue was closed.

lgtm

Why wouldn't it be correct to add delete vm to the end of the negative tests
too?  If they crash, they won't get there, right, and if they incorrectly pass,
then they should do what a passing test does, so they don't crash for the wrong
reason.

Expand Messages | Collapse Messages