Issue 705253002: Include reasons for failing in StateError.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 705253002: Include reasons for failing in StateError. (Closed)

Created:
6 years, 1 month ago by ahe

Modified:
6 years, 1 month ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org, kasperl, lukechurch

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -51 lines)			Patch
M	dart/pkg/dart2js_incremental/lib/library_updater.dart	View	1 2	9 chunks	+48 lines, -37 lines	0 comments	Download
M	dart/site/try/poi/poi.dart	View	1 2 3	1 chunk	+25 lines, -12 lines	0 comments	Download
M	dart/tests/try/poi/library_updater_test.dart	View	1 2 3	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 8 (2 generated)

ahe

Thank you, Johnni. I had to tweak to LibraryUpdater.pendingUpdates. I plan to submit the tweak ...

6 years, 1 month ago (2014-11-10 10:39:56 UTC) #5

ahe

Committed patchset #4 (id:80001) manually as 41625 (presubmit successful).

6 years, 1 month ago (2014-11-10 10:52:03 UTC) #7

Message was sent while issue was closed.

Still LGTM