Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 705173002: ignore exceptions during shutdown (Closed)

Created:
6 years, 1 month ago by danrubel
Modified:
6 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

ignore exceptions during shutdown BUG=dartbug.com/21520 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41585

Patch Set 1 #

Patch Set 2 : update AST class comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -2 lines) Patch
M editor/tools/plugins/com.google.dart.server/src/com/google/dart/server/internal/remote/RemoteAnalysisServerImpl.java View 3 chunks +10 lines, -0 lines 0 comments Download
M editor/tools/plugins/com.google.dart.tools.core/src/com/google/dart/tools/core/analysis/model/LightweightModel_NEW.java View 1 chunk +7 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/ast.dart View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
6 years, 1 month ago (2014-11-06 21:35:31 UTC) #2
scheglov
LGTM
6 years, 1 month ago (2014-11-06 21:39:20 UTC) #3
danrubel
6 years, 1 month ago (2014-11-06 21:40:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41585 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698