Issue 705093002: Allow testing script to run without the package directories being present

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 705093002: Allow testing script to run without the package directories being present (Closed)

Created:
6 years, 1 month ago by ricow1

Modified:
6 years, 1 month ago

Reviewers:
Bill Hesse, Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Allow testing script to run without the package directories being present R=sigmund@google.com, whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=41570

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -13 lines)			Patch
	M	tools/testing/dart/test_suite.dart	View		1 chunk	+16 lines, -13 lines	1 comment	Download

Messages

Total messages: 6 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Siggi Cherem (dart-lang)

lgtm https://codereview.chromium.org/705093002/diff/1/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/705093002/diff/1/tools/testing/dart/test_suite.dart#newcode396 tools/testing/dart/test_suite.dart:396: }); nit: unindent 2

6 years, 1 month ago (2014-11-06 17:10:34 UTC) #5

ricow1

6 years, 1 month ago (2014-11-06 17:14:53 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r41570 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages