Issue 705063003: Suppress inlining of complex Bigint intrinsics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 705063003: Suppress inlining of complex Bigint intrinsics. (Closed)

Created:
6 years, 1 month ago by Vyacheslav Egorov (Google)

Modified:
6 years, 1 month ago

Reviewers:
Florian Schneider, regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Suppress inlining of complex Bigint intrinsics. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41558

Patch Set 1 #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+17 lines, -4 lines)			Patch
M	runtime/vm/method_recognizer.h	View	1 chunk	+8 lines, -0 lines	1 comment	Download
M	runtime/vm/method_recognizer.cc	View	1 chunk	+8 lines, -4 lines	0 comments	Download
M	runtime/vm/object.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Vyacheslav Egorov (Google)

Committed patchset #1 (id:1) manually as 41558 (presubmit successful).

6 years, 1 month ago (2014-11-06 13:57:14 UTC) #3

regis

6 years, 1 month ago (2014-11-06 17:25:19 UTC) #5

Message was sent while issue was closed.

DBC

https://codereview.chromium.org/705063003/diff/1/runtime/vm/method_recognizer.h
File runtime/vm/method_recognizer.h (right):

https://codereview.chromium.org/705063003/diff/1/runtime/vm/method_recognizer...
runtime/vm/method_recognizer.h:388: 
V(_Montgomery, _mulMod, Montgomery_mulMod, 149127024)
should be added as well. It is technically part of Bigint (used for modPow, e.g.
in RSA benchmark).

I'll add it in my next cl.

Little twist: no intrinsic for _estQuotientDigit is provided on arm or mips,
because no 64-bit by 32-bit division instruction exists on these platforms.
Prohibiting inlining is therefore not optimal in that particular case. Since a
runtime call will be used for the division, it probably does not matter.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages