Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issue 705063002: VM: Normalize function result type void to null in the flow graph. (Closed)

Created:
6 years, 1 month ago by Florian Schneider
Modified:
6 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

VM: Normalize function result type void to null in the flow graph. When computing the compile-type there should never be a value of void type. The only value assignable to void is null, so the compiler can use null-type as compile-type for such a value. Before, the compiler would crash with an assertion-failure in checked mode when running with the flag --no-eliminate-type-checks and assigning the result of a static void function to a variable of some type. This CL fixes the issue no matter how the flag is set. We could separately consider removing this flag (it's default is true). R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41563

Patch Set 1 #

Patch Set 2 : fixed AssertAssignable::UpdateType #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -23 lines) Patch
M runtime/vm/flow_graph_type_propagator.cc View 1 3 chunks +18 lines, -22 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Florian Schneider
6 years, 1 month ago (2014-11-06 13:49:49 UTC) #2
Vyacheslav Egorov (Google)
lgtm
6 years, 1 month ago (2014-11-06 13:52:29 UTC) #3
Florian Schneider
PTAL
6 years, 1 month ago (2014-11-06 15:24:09 UTC) #4
Vyacheslav Egorov (Google)
lgtm
6 years, 1 month ago (2014-11-06 15:27:14 UTC) #5
Florian Schneider
6 years, 1 month ago (2014-11-06 15:40:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as r41563 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698