Chromium Code Reviews
DescriptionVM: Normalize function result type void to null in the flow graph.
When computing the compile-type there should never be a value of
void type. The only value assignable to void is null, so the compiler
can use null-type as compile-type for such a value.
Before, the compiler would crash with an assertion-failure in checked
mode when running with the flag --no-eliminate-type-checks and assigning
the result of a static void function to a variable of some type.
This CL fixes the issue no matter how the flag is set. We could separately
consider removing this flag (it's default is true).
R=vegorov@google.com
Committed: https://code.google.com/p/dart/source/detail?r=41563
Patch Set 1 #Patch Set 2 : fixed AssertAssignable::UpdateType #
Messages
Total messages: 6 (1 generated)
|
||||||||||||||||||||||||||||