Issue 705023003: Avoid resetting collectors when calling finnishClasses from deferred.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 705023003: Avoid resetting collectors when calling finnishClasses from deferred. (Closed)

Created:
6 years, 1 month ago by sigurdm

Modified:
6 years, 1 month ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Avoid resetting collectors when calling finnishClasses from deferred. I would love to add a test to this cl, but have not been able to reduce the example given in the bug report. BUG= dartbug.com/21382 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=41556

Patch Set 1 #

Patch Set 2 : Add missing semicolon #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -19 lines)			Patch
	M	pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart	View	1	7 chunks	+37 lines, -19 lines	0 comments	Download
	M	sdk/lib/_internal/compiler/js_lib/shared/embedded_names.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

floitsch

LGTM. Please make sure to add a test, but commit this CL now, to unblock ...

6 years, 1 month ago (2014-11-06 13:17:55 UTC) #3

sigurdm

6 years, 1 month ago (2014-11-06 13:29:11 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 41556 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages