dart2js: Add a type parameter to class Reference in the CPS IR.

dart2js: Add a type parameter to class Reference in the CPS IR.

It's useful to know when references are to continuations or primitives,
and to avoid mixing them --- currently, continuations are not
first-class and cannot appear where a primitive is expected and vice
versa.

BUG=
R=johnniwinther@google.com, karlklose@google.com, sigurdm@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41564

[Kevin Millikin (Google), 2014-11-06 10:35:49]

kmillikin@google.com changed reviewers:
+ karlklose@google.com, sigurdm@google.com

[Kevin Millikin (Google), 2014-11-06 10:35:50]

I'd like to make this change.  What do you think?

https://codereview.chromium.org/705023002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes.dart (right):

https://codereview.chromium.org/705023002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes.dart:32: abstract
class Definition<T extends Definition<T>> extends Node {
Is T the canonical type variable name?

[karlklose, 2014-11-06 11:33:51]

LGTM.

https://codereview.chromium.org/705023002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes.dart (right):

https://codereview.chromium.org/705023002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_nodes.dart:32: abstract
class Definition<T extends Definition<T>> extends Node {
On 2014/11/06 10:35:50, kmillikin wrote:
> Is T the canonical type variable name?

I think it is used in most Dart code. Some tests use E for collections.

[Kevin Millikin (Google), 2014-11-06 13:09:08]

D'oh!  I forgot to hit save on the editor so I didn't include all the changes. 
And I mistook the absence of warnings for absence of runtime errors.

Take another look?

[karlklose, 2014-11-06 13:15:11]

Still LGTM.

[sigurdm, 2014-11-06 13:18:31]

lgtm.
I CC Johnni, it might affect his work on analyzer2dart

[Johnni Winther, 2014-11-06 13:51:55]

johnniwinther@google.com changed reviewers:
+ johnniwinther@google.com

[Johnni Winther, 2014-11-06 13:51:55]

LGTM but I suspect that it will cause checked mode errors in analyzer2dart
(since I create <ir.Definition>[]). Try running the tests in
pkg/analyzer2dart/test in checked mode.

[Kevin Millikin (Google), 2014-11-06 14:13:19]

On 2014/11/06 13:51:55, Johnni Winther wrote:
> LGTM but I suspect that it will cause checked mode errors in analyzer2dart
> (since I create <ir.Definition>[]). Try running the tests in
> pkg/analyzer2dart/test in checked mode.

Thanks, Johnni.  I added fixes to make analyzer2dart tests pass too, and they
found a couple of sites I missed in cps_ir_builder.dart.  Could you sanity check
the changes in patch set #4?

[Johnni Winther, 2014-11-06 14:18:17]

LGTM

[Kevin Millikin (Google), 2014-11-06 15:50:00]

Committed patchset #4 (id:60001) manually as 41564 (presubmit successful).